Build option to disable 64 Disk Drive support

[hissingshark]

There is a longstanding issue since the addition of the 64 Disk Drive support. This is causing some ARM devices to segfault at emulator start.

This commit adds a build option 64DISKDRIVE.
It defaults to 64DISKDRIVE=1 as I expect most devices are unaffected.
Those platforms vulnerable to it can use 64DISKDRIVE=0.

Many Thanks

[hissingshark]

Ah, sorry forgot about the Visual C++ files:

• mupen64plus-core.vcxproj
• mupen64plus-core.vcxproj.filters

I think those explain the AppVeyor build fail. Not familiar with configuring those and no way to test locally (no Windows box here) so will need to read up.

[hissingshark]

It seemed like there was a problem with the checks for desktop builds because the Makefile wasn't setting the pre-processor macro, but now I'm not so sure.
Regardless I've started again and made this a "disable feature" build option. Now checking successfully.

NO_64DD=1 == build without 64 Disk Drive support

I hope this feature is acceptable.

[richard42]

I'm okay with this capability in general (being able to disable 64DD support at build time) but I have a problem with this implementation. There are 50 new #ifdef macro blocks in this merge request (that's a lot), and the function interfaces (internal API) are different depending upon whether or not this macro is defined.

There must be a simpler way to achieve this with fewer #ifdefs, like setting the dd_controller pointer to NULL if it's not supported, and keeping the existing internal API.

[loganmc10]

I think it would be a lot better to figure out why the new dynarec crashes with 64DD support, there shouldn't really be a reason to remove DD support like this

[fzurita]

Also, Android does not appear to have this problem. I agree with @loganmc10, if @hissingshark could provide a backtrace to the core dump, I'm sure the issue could be figured out.