Reduce platform-specific ifdefs. #85
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zip code uses 64-bit fopen(), etc by calling fopen64() and (on platforms that don't have it) #define-ing fopen fopen64. But this is redundant. glibc is just about the only libc out there that needs a separate fopen64(), etc--most C libraries, including other Linux C libraries, simply use a 64-bit off_t. glibc can do this too, by compiling programs with _FILE_OFFSET_BITS=64. And the zip code does this.
|
Why not sending this first to https://github.com/madler/zlib and the importing the new version in mupen64plus-core? |
Member
|
Hi @bentley. I have the impression you are not on the good project. :) From what I see, you should PR this project first. Once it's done and minizip release a stable version, it could be interesting for us to update to this stable version. Sorry but I'm not sure this will be ever merged. Any idea @richard42? |
Contributor
Author
|
I’ll push it to the various upstreams. But since the details leak through to the Unix makefile, it is worth bringing up here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zip code uses 64-bit fopen(), etc by calling fopen64() and (on
platforms that don't have it) #define-ing fopen fopen64.
But this is redundant. glibc is just about the only libc out there that
needs a separate fopen64(), etc—most C libraries, including other Linux
C libraries, simply use a 64-bit off_t. glibc can do this too, by
compiling programs with _FILE_OFFSET_BITS=64. And the zip code does this.