Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add courtesy keysig to last measure even if it is followed by frame #25420

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sammik
Copy link
Contributor

@sammik sammik commented Nov 3, 2024

Resolves: #22256
Resolves: #19759

  • creating courtesy keysig was disabled by MeasureLayout::createEndBarLines(measure, **false**, ctx);, which sets ElementFlag::KEYSIG of measurebase to false, so before adding trailer, we need to re-createEndBarLines with truthy isLastMeasureInSystem value
  • this was already (almost) done, with one exception - it processed last measureBase of system, but we need last real measure (not frame)

keysig-frame

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants