Fix MSVC compiler and Visual Studio warnings #25425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jojo-Schmitz
commented
Nov 4, 2024
•
Jojo-Schmitz
commented
- reg.: declaration of 'bendFor' hides previous local declaration (C4456)
- reg.: declaration of 'groupBox' hides class member (C4458)
- reg.: Function definition for 'xMostEdgeAtY' not found (VCR001) and remove a superfluous include
- reg. 'argument': conversion from 'size_t' to 'int', possible loss of data (C4267)
Jojo-Schmitz
force-pushed
the
compiler-warnigs
branch
3 times, most recently
from
a56aa54
to
f38c4fc
Compare
Jojo-Schmitz
force-pushed
the
compiler-warnigs
branch
2 times, most recently
from
ff44645
to
888266d
Compare
Jojo-Schmitz
changed the title
cbjeukendrup
reviewed
Nov 7, 2024
cbjeukendrup
reviewed
Nov 7, 2024
Jojo-Schmitz
force-pushed
the
compiler-warnigs
branch
2 times, most recently
from
f2bceb0
to
dbf6737
Compare
reg.: declaration of 'bendFor' hides previous local declaration (C4456)
reg.: declaration of 'groupBox' hides class member (C4458)
reg.: Function definition for 'xMostEdgeAtY' not found (VCR001) Also removed an unneeded include that came in via the same PR as the above dead code
reg. 'argument': conversion from 'size_t' to 'int', possible loss of data (C4267)
Jojo-Schmitz
force-pushed
the
compiler-warnigs
branch
from
dbf6737
to
9490636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.