Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25452: Fixing indent on menu items with check marks and/or icons #25453

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krasko78
Copy link
Contributor

@krasko78 krasko78 commented Nov 6, 2024

Resolves: #25452

The widths of the labels for the check mark and the icon were set to 16 which was on the low side. The Layout seems to respect those widths only for empty labels (no check mark, no icon): try changing those widths to 100 for example. The result is only the menu items without check marks and icons are indented, those with check marks and/or icons do not move. Therefore I have set the preferred widths on the Layout instead.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@krasko78 krasko78 force-pushed the 25452-TextsOfMenuItemWithCheckMarksOrIconsAreIndented branch from adef42c to 1b9f563 Compare November 6, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Texts of menu items with check marks and/or icons are slightly indented
2 participants