KDDockWidgets update to v2 #25468
Draft
KDDockWidgets update to v2 #25468
+159,797
−29,000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is required for Qt 6.5.0
It was deprecated in Qt 6.4. Basically, just need to specify `globalPos`
It was deprecated during the Qt 6.8 beta phase, but it looks like this deprecation has been postponed to Qt 6.9. Anyway, there is now a better alternative called `checkStateChanged`, that uses `Qt::CheckState` instead of `int`.
To be sure that we're using a new-enough version for all Qt 6.8 features
I verified that they don't do anything scary, so let's use them, to keep our code in line with the documentation, and to be sure that we're ready to use modern Qt/CMake possibilities.
When an error occurs while creating a component, don't cause even more errors by reading from `null` at `dialogObj.object.objectId`
cbjeukendrup
reviewed
Nov 9, 2024
| navigation.order: 1 | ||
| // MainToolBar { | ||
| // id: toolBar | ||
| // navigation.section: root.topToolKeyNavSec |
There was a problem hiding this comment.
It is not a property of root anymore:
Suggested change
| // navigation.section: root.topToolKeyNavSec | |
| // navigation.section: topToolbarKeyNavSec |
needed for using private classes like Item_p
Private KDDockWidgets classes use KDBindings, which in turn uses the emit term, which leads to compilation errors. Here we turn off the use of emit - now we use Q_EMIT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not finished, just for build and try