Avoid state reset on paste #29393
Merged
Avoid state reset on paste #29393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8c286aa.
cbjeukendrup
approved these changes
Aug 21, 2025
Eism
approved these changes
Aug 22, 2025
mike-spa
added a commit
to mike-spa/MuseScore
that referenced
this pull request
Aug 22, 2025
Avoid state reset on paste
Merged
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 23, 2025
Partial backport ogf musescore#29393, commit 3
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 23, 2025
Partial backport ogf musescore#29393, commit 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #27399
But without the hack introduces in #27411. Looks like the much simpler solution is just for Spanner::triggerLayout to check if the tick is correctly set and if not don't trigger.
Resolves: this issue ⬇️ but without hack introduced in 8c286aa.
Screen.Recording.2025-08-21.at.12.50.52.PM.mov