Fix crash with custom tick formatters/locators and Est()#3912
Open
Mr-Neutr0n wants to merge 1 commit into
Open
Fix crash with custom tick formatters/locators and Est()#3912Mr-Neutr0n wants to merge 1 commit into
Mr-Neutr0n wants to merge 1 commit into
Conversation
When using so.Est() with custom formatters like PercentFormatter or locators like LogLocator, the scale setup for derived coordinate variables (ymin/ymax) would share the same locator/formatter instances as the main variable's scale. This caused the locator's internal axis reference to be overwritten to point at a PseudoAxis, which lacked the _view_interval attribute and other methods that matplotlib expects. Fix this by deepcopying locators and formatters in _get_scale() so each scale gets independent instances, and also initialize _view_interval in PseudoAxis.__init__ as a defensive measure. Fixes mwaskom#3585
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3585
When using
so.Est()with custom matplotlib formatters (e.g.PercentFormatter) or locators (e.g.LogLocator), the plot crashes withAttributeError: 'PseudoAxis' object has no attribute '_view_interval'(or'_get_shared_axis').The root cause is that
_get_scale()returns locator/formatter instances that are shared across multiple calls to_setup(). When a scale is set up for derived coordinate variables likeymin/ymax(which happens withEst()), aPseudoAxisis created internally, andset_default_locators_and_formattersoverwrites the shared locator's axis reference to point at thisPseudoAxis. The main variable's scale then tries to use the locator, which now references aPseudoAxisthat lacks attributes like_view_interval.Changes
_get_scale()so each scale setup gets independent instances that won't interfere with each other_view_intervalinPseudoAxis.__init__as a defensive measure, matching the existing pattern for_data_intervalTest plan
PercentFormatterandLogLocatorwithEst())