-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix video-streamer zombie processes #1590
base: develop
Are you sure you want to change the base?
Conversation
113ea91
to
093273c
Compare
093273c
to
0726ec0
Compare
So In this line, when running manually the pre-commits on python 3.10 it changed
to
which was not detected by the automatic local pre-commits (3.10) but crashed the CI running on 3.11, just in case somebody encounters this issue |
# This is to avoid `Server.kill_processes`, that makes the build return non-zero | ||
server.flask.testing = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm removing this testing flag on a few occasions in the code, since it is now no longer needed
That is curious... Could it be that somewhere somehow a different version of Poetry was used? I think the version is pinned in the pre-commit hook, so it should be safe from such issues. |
I thought so as well at the beginning and my first try was to use the |
OK... that does not make much sense to me. Some bug somewhere maybe... |
This PR closes #1577 .
This PR updates
pyproject.toml
to use the version ofmxcubecore
fixing the above issue. The fix was introduced in mxcube/mxcubecore#1169 . It also moves thevideo-streamer
dependency intomxcubecore
and removes it from here.Additionally, I had to modify the tests, previously in our
atexit
register, we could decide to not kill any processes, as it was called in mxcubeweb. This is now different and we will see someProcessLookUpError
since they are not well synchronized with pytests handlers. Instead, this PR introduces amonkeypatch
for theatexit.register
function and to make sure to kill any child processespsutil
is used after each test.Bonus of this PR:
Using the latest version of mxcubecore will also fix a security vulnerability introduced by
jinja2
.