Skip to content

Fix: handle new GitHub 2FA form structure to prevent NoneType error #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WinDyAlphA wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: handle new GitHub 2FA form structure to prevent NoneType error #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion gitfive/lib/objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from pathlib import Path
from time import sleep
from datetime import datetime
import re

from rich.console import Console
from rich import print as rprint
Expand Down Expand Up @@ -307,7 +308,11 @@ async def login(self, force=False):
req = await self._as_client.get("https://github.com/sessions/two-factor/app")
body = bs(req.text, 'html.parser')
authenticity_token = body.find("form", {"action": "/sessions/two-factor"}).find("input", {"name": "authenticity_token"}).attrs["value"]
msg = body.find("form", {"action": "/sessions/two-factor"}).find("div", {"class": "mt-3"}).text.strip().split("\n")[0]
twofa_form = body.find("form", attrs={"action": re.compile(r"/sessions/two-factor")})
if not twofa_form:
twofa_form = body.find("form", id=re.compile(r"two-factor", re.I))
msg = (twofa_form.get_text(" ", strip=True) if twofa_form else "Two-factor challenge")

rprint(f'[bold]🗨️ Github :[/bold] [italic]"{msg}"')
otp = pwinput("📱 Code => ")
data = {
Expand Down