Skip to content

OD-921 Fix package volume and sizes calculation #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sekulich-mygento wants to merge 1 commit into from
Closed

OD-921 Fix package volume and sizes calculation #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 9 additions & 26 deletions Helper/Dimensions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,35 +10,16 @@

class Dimensions
{
/**
* @var \Magento\Catalog\Model\ResourceModel\Product
*/
private $productResource;

/**
* @var \Magento\Store\Model\StoreManagerInterface
*/
private $storeManager;

/**
* @var \Mygento\Base\Api\ProductAttributeHelperInterface
*/
private $attrHelper;

/**
* @param \Mygento\Base\Api\ProductAttributeHelperInterface $attrHelper
* @param \Magento\Store\Model\StoreManagerInterface $storeManager
* @param \Magento\Catalog\Model\ResourceModel\Product $productResource
*/
public function __construct(
\Mygento\Base\Api\ProductAttributeHelperInterface $attrHelper,
\Magento\Store\Model\StoreManagerInterface $storeManager,
\Magento\Catalog\Model\ResourceModel\Product $productResource,
) {
$this->attrHelper = $attrHelper;
$this->storeManager = $storeManager;
$this->productResource = $productResource;
}
private \Mygento\Base\Api\ProductAttributeHelperInterface $attrHelper,
private \Magento\Store\Model\StoreManagerInterface $storeManager,
private \Magento\Catalog\Model\ResourceModel\Product $productResource,
) {}

/**
* Get items sizes
Expand Down Expand Up @@ -122,9 +103,11 @@ public function dimenAlgo(array $dimensions): array
}

foreach ($dim as $d) {
($d['width'] > $result['width']) ? $result['width'] = $d['width'] : '';
($d['height'] > $result['height']) ? $result['height'] = $d['height'] : '';
$result['length'] += $d['length'];
$length = max($d['length'], $d['width']);
$width = min($d['length'], $d['width']);
($length > $result['length']) ? $result['length'] = $length : '';
($width > $result['width']) ? $result['width'] = $width : '';
$result['height'] += $d['height'];
}
$result['volume'] = $result['length'] * $result['height'] * $result['width'];

Expand Down
Loading