8445 individual topic page #8577
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a way to detect if inputs inside js-collapse-content are being used was added. If that is the case, then js-collapse-content will remain open if the page is reloaded. The idea is to make it more UX-friendly for users actively using the inputs inside js-collapse-content and don't have to reopen every time the page reloads. - Added an optional reset button that clears the inputs inside .js-collapse-content
- Previous calendar was not passing contrast test. New colour passes AAA. - Replaced PNG with SVG for better definition
Currently the focus state is barely noticeable, which is not ideal for people using keyboard or assistive devices to navigate the site. This commits add a box-shadow and outline when focusing.
- Added visually-hidden class to h2 elements in #header_right, considering each one has only two items, which are easy to scan, so I don't think those headings contributed. This should also help make that section use less vertical space, - Removed odd margin-left to a.track-request-action, that was breaking the - Increased the contrast ratio for the borders inside .filter-request-types - Made some changes in the spacing on #header_left and .results_section so there is not much empty space between sections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes part of: #8445
What does this do?
Change layout for
/listand individual topic page:Advanced search
Improved contrast of calendar icons
Added collapse button component
Improved focus state for input fields
Why was this needed?
Implementation notes
Screenshots
Notes to reviewer
Have you updated the changelog? If this is not necessary, put square brackets around this: skip changelog