[WW][Sutton] Add flow for container request cancellations.

[neprune]

[skip changelog]

for https://github.com/mysociety/societyworks/issues/4805

[codecov]

Codecov Report

❌ Patch coverage is 86.27451% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.61%. Comparing base (ccea3d6) to head (097c9a3).

Files with missing lines	Patch %	Lines
perllib/FixMyStreet/App/Controller/Waste.pm	91.66%	0 Missing and 2 partials ⚠️
perllib/FixMyStreet/App/Controller/Waste/Echo.pm	0.00%	2 Missing ⚠️
perllib/FixMyStreet/Roles/Cobrand/Waste.pm	75.00%	0 Missing and 2 partials ⚠️
perllib/FixMyStreet/Cobrand/Sutton.pm	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5742      +/-   ##
==========================================
- Coverage   82.64%   82.61%   -0.04%     
==========================================
  Files         457      458       +1     
  Lines       35710    35761      +51     
  Branches     5821     5828       +7     
==========================================
+ Hits        29514    29545      +31     
- Misses       4501     4516      +15     
- Partials     1695     1700       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[dracos]

Only real request is to make the Sutton specific things the default, with a feature flag; other two are just question/comments :)

[dracos]

Only the one thing, sorry :)

[dracos]

Thanks :)

[neprune]

New commits address bugs from https://github.com/mysociety/societyworks/issues/5269.

[dracos]

Looks good :)

[neprune]

@dracos taking the approach of letting the update logic filter out the echo cancellation because of the matching text & user, as discussed.

[dracos]

👍

[neprune]

New changes:

1. Remove state change text in cancellation update.
2. Don't alert on the cancellation update back from Echo.
   Both verified on staging.

[dracos]

Looks fine - I guess only question is if in this state we don't want to have an update at all (but then, I think we won't because the text and state will match so it's about to get hidden anyway).

[dracos]

Just checking (I think we discussed this, but have forgotten) - this is just in case it's not already caught/hidden by the 'identical update' checking (now that we use the template)? Do we want to only suppress the alert, or if we're here, skip the update entirely?

[neprune]

Yeah on staging the update was still getting through, I guess because the template was not picked up so text wasn't matching, but I thought rather than figure that out better to just be explicit anyway. The reason I went for suppression rather than skipping was in case we wanted to keep a log on the report of when we get confirmation Echo that it was actually cancelled.

[dracos]

Oh yes, the template isn't being picked up because there isn't a state change (so it's not even looking); I wonder if it should be in that case, but that seems like a bigger thing.