-
-
Notifications
You must be signed in to change notification settings - Fork 272
[Brent] Adds container request form #5748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #5748 +/- ##
===========================================
- Coverage 82.62% 68.09% -14.54%
===========================================
Files 458 43 -415
Lines 35787 5438 -30349
Branches 5836 0 -5836
===========================================
- Hits 29569 3703 -25866
+ Misses 4516 1735 -2781
+ Partials 1702 0 -1702 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dracos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have chatted about it, happy to discuss more - think for now we want the minimum they've asked for, we don't know if the others will ever be needed, and it should probably use the existing replacement page (which would change its next to go to your page of new questions if it's grey bin and extra. I assume the ordered_previously would still kick in and auto-refuse as now.) rather than have a different flow for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - some small changes to make, plus a problem with the logic.
| } | ||
|
|
||
|
|
||
| sub waste_post_report_creation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the detail parts of this would be better done in waste_munge_request_data which sets the detail in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one hasn't been done, but don't think it really matters, happy to leave it here for now.
dracos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing all that :) I agree when they test they might raise the issue you have, but I think this is fine for them to try, it does what they're after
0e4782e to
e12473d
Compare
|
c3cd794 as rebased - Fixes issues discussed in https://mysociety.slack.com/archives/C05KHS09UKG/p1765185475660889 |
4ffadc6 to
c3cd794
Compare
|
070ecac is the changes to make all grey containers a referral |
dracos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think I approved this in Slack already
070ecac to
95242ab
Compare
Adds form to request refuse containers. Filter requests for extra containers to calculate whether request will be unsuccessful and automate the response. mysociety/societyworks#5120
95242ab to
27d03de
Compare
Add a form for ordering a grey refuse container to collect information about the request and send it by email to the Council.
If the household is not going to be successful in its application according to certain data collected, pre-empt the application by stopping the process.
Prohibit reapplication for a period of two weeks to prevent unnecessary reapplications.
https://github.com/mysociety/societyworks/issues/5120#issuecomment-3556888655
[skip changelog]