Skip to content

Conversation

@MorayMySoc
Copy link
Contributor

@MorayMySoc MorayMySoc commented Nov 20, 2025

Add a form for ordering a grey refuse container to collect information about the request and send it by email to the Council.

If the household is not going to be successful in its application according to certain data collected, pre-empt the application by stopping the process.

Prohibit reapplication for a period of two weeks to prevent unnecessary reapplications.

https://github.com/mysociety/societyworks/issues/5120#issuecomment-3556888655
[skip changelog]

@MorayMySoc MorayMySoc requested a review from dracos November 20, 2025 14:57
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.09%. Comparing base (56204ac) to head (27d03de).
⚠️ Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (56204ac) and HEAD (27d03de). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (56204ac) HEAD (27d03de)
15 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5748       +/-   ##
===========================================
- Coverage   82.62%   68.09%   -14.54%     
===========================================
  Files         458       43      -415     
  Lines       35787     5438    -30349     
  Branches     5836        0     -5836     
===========================================
- Hits        29569     3703    -25866     
+ Misses       4516     1735     -2781     
+ Partials     1702        0     -1702     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have chatted about it, happy to discuss more - think for now we want the minimum they've asked for, we don't know if the others will ever be needed, and it should probably use the existing replacement page (which would change its next to go to your page of new questions if it's grey bin and extra. I assume the ordered_previously would still kick in and auto-refuse as now.) rather than have a different flow for it

@MorayMySoc MorayMySoc requested a review from dracos November 25, 2025 13:56
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - some small changes to make, plus a problem with the logic.

}


sub waste_post_report_creation {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the detail parts of this would be better done in waste_munge_request_data which sets the detail in the first place.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one hasn't been done, but don't think it really matters, happy to leave it here for now.

@MorayMySoc MorayMySoc requested a review from dracos December 5, 2025 13:21
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all that :) I agree when they test they might raise the issue you have, but I think this is fine for them to try, it does what they're after

@mysociety-pusher mysociety-pusher force-pushed the 5120-add-container-request-form branch from 0e4782e to e12473d Compare December 5, 2025 15:36
@MorayMySoc
Copy link
Contributor Author

MorayMySoc commented Dec 9, 2025

c3cd794 as rebased - Fixes issues discussed in https://mysociety.slack.com/archives/C05KHS09UKG/p1765185475660889

@MorayMySoc MorayMySoc requested a review from dracos December 9, 2025 16:02
@mysociety-pusher mysociety-pusher force-pushed the 5120-add-container-request-form branch from 4ffadc6 to c3cd794 Compare December 9, 2025 16:34
@MorayMySoc MorayMySoc requested a review from dracos December 9, 2025 17:05
@MorayMySoc
Copy link
Contributor Author

070ecac is the changes to make all grey containers a referral

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think I approved this in Slack already

@dracos dracos force-pushed the 5120-add-container-request-form branch from 070ecac to 95242ab Compare January 8, 2026 11:36
Adds form to request refuse containers.

Filter requests for extra containers to calculate
whether request will be unsuccessful and automate
the response.

mysociety/societyworks#5120
@dracos dracos force-pushed the 5120-add-container-request-form branch from 95242ab to 27d03de Compare January 12, 2026 14:25
@dracos dracos merged commit 27d03de into master Jan 12, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants