Skip to content

Conversation

@nephila-nacrea
Copy link
Contributor

@nephila-nacrea nephila-nacrea commented Nov 27, 2025

@nephila-nacrea nephila-nacrea self-assigned this Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.25%. Comparing base (2ffc4b9) to head (c69391a).
⚠️ Report is 37 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Northumberland.pm 66.66% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5755      +/-   ##
==========================================
+ Coverage   82.66%   83.25%   +0.59%     
==========================================
  Files         455      456       +1     
  Lines       35512    37857    +2345     
  Branches     5783     6408     +625     
==========================================
+ Hits        29355    31519    +2164     
- Misses       4467     4604     +137     
- Partials     1690     1734      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nephila-nacrea nephila-nacrea force-pushed the nland-inform-shortlisted branch from 830b843 to f47dc89 Compare November 27, 2025 20:15
@nephila-nacrea nephila-nacrea marked this pull request as ready for review November 27, 2025 20:17
@nephila-nacrea nephila-nacrea changed the title [N/land] Send email to assignee when report shortlisted [N/land] Send email & SMS to assignee when report shortlisted Nov 27, 2025
@lizettal
Copy link
Contributor

lizettal commented Dec 4, 2025

@dracos will you have a chance to review this one this week?

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to go on staging now, my comments are all just tidying, don't affect the behaviour, looks good

@nephila-nacrea nephila-nacrea requested a review from dracos December 5, 2025 10:26
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants