-
-
Notifications
You must be signed in to change notification settings - Fork 272
[Kingston] add flow for reporting bins not returned or contents spilled #5768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5768 +/- ##
==========================================
+ Coverage 82.59% 83.14% +0.54%
==========================================
Files 457 457
Lines 35689 38061 +2372
Branches 5814 6366 +552
==========================================
+ Hits 29479 31646 +2167
- Misses 4515 4694 +179
- Partials 1695 1721 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
700ebbf to
2c9d9c6
Compare
2c9d9c6 to
81d14ec
Compare
dracos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some refactoring mostly I think :)
dracos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny issue with the email template to resolve, symlink thing I'm sure we can fix.
| [% END %] | ||
|
|
||
| [% ELSIF cobrand.moniker == 'kingston' AND report.category == 'Request new container' %] | ||
| [% ELSIF cobrand.moniker == 'kingston'%] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one more kingston check unneeded in the second sub-IF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And same issue with missed collections as the HTML
dracos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo; still got that superfluous ELSIF cobrand.moniker == 'kingston' in the text email but doesn't matter if it's left in :)
e195700 to
02b6e09
Compare
This is mostly based on the Sutton code with a few Kingston specific changes to add checkbox extra details to the bin not returned, plus an extra message for FAS properties for spillages.
Fixes mysociety/societyworks#5245
Fixes mysociety/societyworks#5246
[skip changelog]