Skip to content

Conversation

@davea
Copy link
Member

@davea davea commented Dec 23, 2025

The Gloucestershire cobrand was allowing anonymous reports for Gloucester City categories, which should not be permitted since Gloucester's cobrand does not enable anonymous reporting.

For FD-6454

[skip changelog]

The Gloucestershire cobrand was allowing anonymous reports for
Gloucester City categories, which should not be permitted since
Gloucester's cobrand does not enable anonymous reporting.

For FD-6454
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.63%. Comparing base (151c8cf) to head (0ac34c8).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Gloucestershire.pm 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5794      +/-   ##
==========================================
- Coverage   82.64%   82.63%   -0.02%     
==========================================
  Files         457      457              
  Lines       35716    35722       +6     
  Branches     5822     5825       +3     
==========================================
+ Hits        29519    29520       +1     
- Misses       4501     4505       +4     
- Partials     1696     1697       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davea davea marked this pull request as ready for review December 23, 2025 13:36
@davea davea requested a review from dracos December 23, 2025 13:37
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is okay, but as discussed after checking it perhaps it is easier to remove the allow_anonymous_reports function here and set the admin tickboxes instead, then that works without needing special behaviour.

=cut

sub allow_anonymous_reports { 'button' }
sub allow_anonymous_reports {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is the same as Default's now, apart from it doesn't have the anonymous_allowed check. So perhaps here instead we could remove this function entirely and tick every category for Gloucestershire to have the same effect without special code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants