Conversation
sagepe
reviewed
Aug 21, 2026
sagepe
reviewed
Aug 21, 2026
dracos
reviewed
Aug 24, 2026
| # with: | ||
| # rootPassword: 'password' | ||
| # sqlMode: 'ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION' | ||
| - uses: niden/actions-memcached@v8 |
Member
There was a problem hiding this comment.
Can we use pinned commit hashes here, if we're updating this file anyway
dracos
force-pushed
the
php82
branch
2 times, most recently
from
August 25, 2026 20:17
e07f905 to
6bacdf9
Compare
- remove unused facebook connection - remove password-compat (old polyfill)
Xapian is loaded in the server now.
This is now a fatal error.
dracos
force-pushed
the
php82
branch
3 times, most recently
from
August 27, 2026 07:12
9620837 to
d972ba5
Compare
The final argument to error handler was removed in PHP8 See: https://www.php.net/manual/en/function.set-error-handler.php Include file/line details in exception handling.
These were silent in PHP7.
IP could be v6, name column can be longer, and we have UTF-8 characters in more places. These were all silent in PHP7.
These all silently failed in PHP7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch updates the docker to bookwork and mariadb 11.8.
A few small fixes needed but generally seems ok.
The Claude scan for the string to number change is here - a few things flagged but I haven't made any changes due to it because it all seems fine from our point of view. That's not conclusive obviously, but suggests we're not going to find massive issues due to that change.