fix: Remove deprecated gnome-keyring code and add partition TABLESPAC… #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E/NODEGROUP support This commit addresses technical debt and improves the codebase: 1. **Removed deprecated gnome-keyring references** - Cleaned up legacy gnome-keyring includes from main.cpp - Updated environment variable from WB_NO_GNOME_KEYRING to WB_NO_KEYRING - Code already uses libsecret for password storage, just removed old references 2. **Added TABLESPACE and NODEGROUP support for partitions** - Implemented missing partition options in SQL generation (module_db_mysql.cpp:130-136) - Supports TABLESPACE for NDB and InnoDB storage engines - Supports NODEGROUP for NDB Cluster storage engine - Resolves long-standing TODO comment These changes improve developer experience by removing deprecated code warnings and add missing functionality for MySQL partition management features. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…E/NODEGROUP support
This commit addresses technical debt and improves the codebase:
Removed deprecated gnome-keyring references
Added TABLESPACE and NODEGROUP support for partitions
These changes improve developer experience by removing deprecated code warnings and add missing functionality for MySQL partition management features.
🤖 Generated with Claude Code