docs: Revive 0.35 examples #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few changes: - client side is not creating a router - allow specifying secret key - don't publish discovery info for client
changes: - client does not create a router - removed progress for now
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/121/docs/iroh_blobs/ Last updated: 2025-07-24T08:05:42Z |
rklaehn
requested review from
Frando and
matheus23
and removed request for
Frando
I think it is nice if you can use the examples without the --features examples feature flag.
matheus23
reviewed
Jul 24, 2025
Co-authored-by: Philipp Krüger <[email protected]>
This reverts commit d38e92b.
matheus23
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add back the examples that were removed when moving from 0.35 to 0.9x.
Breaking Changes
None
Notes & open questions
How much should we bikeshed the progress reporting in the examples, using console and indicatif crates? On the one hand it is nice, on the other hand it makes the examples more complex.
I think we might put basic progress display for import, download and export into the util crate. But I think it would be nice if we could get by without the
--features exampesfeature flag for most or all examples, so maybe not use console and indicatif so we don't have to have it as dev dependencies.I changed the transfer example to use clap like the other examples. I hope you don't mind, @matheus23.
Change checklist
Implements #120
Implements #117