Skip to content

refactor: Remove gc tests #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 29, 2024
Merged

refactor: Remove gc tests #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c63bae3
refactor: remove all blobs gc related tests
rklaehn Nov 29, 2024
412e978
downgrade testdir
rklaehn Nov 29, 2024
d32b28d
gah
rklaehn Nov 29, 2024
f0a0044
Merge branch 'main' into remove-gc-tests
rklaehn Nov 29, 2024
fad7239
use top level ALPN reexport
rklaehn Nov 29, 2024
c084faf
Merge branch 'main' into remove-gc-tests
rklaehn Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 56 additions & 96 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ parking_lot = "0.12.3"
testresult = "0.4.1"
nested_enum_utils = "0.1.0"
iroh-io = "0.6.1"
testdir = "0.9.1"
testdir = "0.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the downgrade?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a wild shot in the dark to get the MSRV test to pass.

Got this in the MSRV test

error: package `cargo-platform v0.1.9` cannot be built because it requires rustc 1.78 or newer, while the currently active rustc version is 1.76.0
Either upgrade to rustc 1.78 or newer, or use
cargo update [email protected] --precise ver
where `ver` is the latest version of `cargo-platform` supporting rustc 1.76.0

and testdir seems to be the culprit

❯ cargo tree -i cargo-platform
cargo-platform v0.1.9
└── cargo_metadata v0.14.2
    └── testdir v0.9.1
        [dev-dependencies]
        └── iroh-docs v0.28.0 (/Users/rklaehn/projects_git/iroh-docs)

So I would have to do some kind of bisect to find out when testdir started using a version of cargo-platform that requires rustc 1.78. Instead I just chose a random number.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @flub

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we checking MSRV on dev-dependencies?

data-encoding = "2.6.0"

[features]
Expand Down
Loading
Loading