Skip to content

Conversation

@dignifiedquire
Copy link
Contributor

@dignifiedquire dignifiedquire commented Oct 15, 2025

Description

These now live in https://github.com/n0-computer/iroh-tickets and will be published as iroh-tickets.

Breaking Changes

  • iroh-base::ticket has been removed

Notes

The 0rtt and transfer examples now use just EndpointIds to connect, and not tickets anymore. Otherwise we end up in a problematic dependency tree. If necessary I can add direct addresses and relay urls to the transfer example again

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: b5daa97

@dignifiedquire dignifiedquire added this to the v0.94 milestone Oct 15, 2025
@dignifiedquire dignifiedquire self-assigned this Oct 15, 2025
@n0bot n0bot bot added this to iroh Oct 15, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Oct 15, 2025
Copy link
Contributor

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

Often to use tickets you had to explicitly import iroh-base, since they were not reexported by iroh. So it is not too inconvenient to depend on another crate.

Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a PR n0-computer/chuck#80 to update netsim to use the endpoint ID. However many of those are air gaped and don't have standard discovery mechanics available. The ticked contained direct addr info which was needed for it to work in this environment. Dunno if relay url is needed because they all are configured to the same test spawned one so that should be fine I think.

You can keep re-running this job till it passes with your changes to check:
https://github.com/n0-computer/iroh/actions/runs/18645720236/job/53152491327

@Frando
Copy link
Member

Frando commented Oct 20, 2025

I'd propose to just use https://github.com/n0-computer/iroh-tickets in chuck then, no need to make it use discovery.

@dignifiedquire
Copy link
Contributor Author

I can also add manual passing of ip addrs to the example if that's what we need for chuck

@github-actions
Copy link

github-actions bot commented Oct 20, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3544/docs/iroh/

Last updated: 2025-10-21T11:07:04Z

@ramfox
Copy link
Member

ramfox commented Oct 20, 2025

added --remote-relay-url and --remote-direct-address as fields on the transfer example. Hopefully that might help alleviate pressure on chuck now that tickets have been removed? @Arqu

#[clap(long)]
remote_relay_url: Option<RelayUrl>,
#[clap(long)]
remote_direct_address: Vec<SocketAddr>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remote_direct_addr :)

@github-actions
Copy link

refactor-tickets.2d367f9
Perf report:

test case throughput_gbps throughput_transfer
iroh_latency_200ms 1_to_1 1.24 2.92
iroh_latency_200ms 1_to_3 4.16 11.76
iroh_latency_200ms 1_to_5 6.45 16.20
iroh_latency_200ms 1_to_10 10.29 19.83
iroh_latency_200ms 2_to_2 2.47 5.81
iroh_latency_200ms 2_to_4 5.14 12.87
iroh_latency_200ms 2_to_6 8.17 22.44
iroh_latency_200ms 2_to_10 12.49 29.96
iroh 1_to_1 1.25 3.02
iroh 1_to_3 4.06 11.00
iroh 1_to_5 6.45 16.24
iroh 1_to_10 10.49 20.59
iroh 2_to_2 2.51 6.05
iroh 2_to_4 5.21 13.31
iroh 2_to_6 8.20 22.67
iroh 2_to_10 12.69 31.14
iroh_latency_20ms 1_to_1 1.25 2.97
iroh_latency_20ms 1_to_3 3.94 10.18
iroh_latency_20ms 1_to_5 6.29 15.22
iroh_latency_20ms 1_to_10 9.92 18.48
iroh_latency_20ms 2_to_2 2.48 5.90
iroh_latency_20ms 2_to_4 5.17 13.05
iroh_latency_20ms 2_to_6 7.92 20.86
iroh_latency_20ms 2_to_10 12.53 30.30
iroh_relay_only 1_to_1 2.02 2.12
iroh_relay_only 1_to_3 4.95 5.16
iroh_relay_only 1_to_5 4.56 4.66
iroh_relay_only 1_to_10 3.87 3.91
iroh_relay_only 2_to_2 4.76 5.06
iroh_relay_only 2_to_4 7.88 8.29
iroh_relay_only 2_to_6 8.46 8.77
iroh_relay_only 2_to_10 8.22 8.39
iroh_cust_10gb 1_to_1 2.30 2.58
iroh_cust_10gb 1_to_3 10.04 11.90
iroh_cust_10gb 1_to_5 13.60 15.58
iroh_cust_10gb 1_to_10 10.03 10.52
iroh_cust_10gb 2_to_2 5.20 5.92
iroh_cust_10gb 2_to_4 8.91 9.95
iroh_cust_10gb 2_to_6 8.86 9.52
iroh_cust_10gb 2_to_10 9.02 9.41

@Arqu
Copy link
Collaborator

Arqu commented Oct 21, 2025

Netsim is now passing https://github.com/n0-computer/iroh/actions/runs/18645720236/job/53255016686
With this pr n0-computer/chuck#80

We will need to coordinate the merges around these not to screw up other PRs

@dignifiedquire dignifiedquire added this pull request to the merge queue Oct 21, 2025
Merged via the queue into main with commit 25cea67 Oct 21, 2025
72 of 79 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Oct 21, 2025
@Arqu Arqu deleted the refactor-tickets branch October 21, 2025 12:27
@dpc
Copy link

dpc commented Dec 30, 2025

At the time of writting https://docs.rs/iroh/latest/iroh/discovery/static_provider/struct.StaticProvider.html still mentions and links (broken) to EndpointTicket.

@flub
Copy link
Contributor

flub commented Jan 5, 2026

At the time of writting https://docs.rs/iroh/latest/iroh/discovery/static_provider/struct.StaticProvider.html still mentions and links (broken) to EndpointTicket.

Thanks, fix here: #3814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

8 participants