-
Notifications
You must be signed in to change notification settings - Fork 335
refactor(iroh-base)!: move tickets into their own crate #3544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rklaehn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine.
Often to use tickets you had to explicitly import iroh-base, since they were not reexported by iroh. So it is not too inconvenient to depend on another crate.
d7dc269 to
d4c4563
Compare
d4c4563 to
fac5537
Compare
Arqu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a PR n0-computer/chuck#80 to update netsim to use the endpoint ID. However many of those are air gaped and don't have standard discovery mechanics available. The ticked contained direct addr info which was needed for it to work in this environment. Dunno if relay url is needed because they all are configured to the same test spawned one so that should be fine I think.
You can keep re-running this job till it passes with your changes to check:
https://github.com/n0-computer/iroh/actions/runs/18645720236/job/53152491327
|
I'd propose to just use https://github.com/n0-computer/iroh-tickets in chuck then, no need to make it use discovery. |
|
I can also add manual passing of ip addrs to the example if that's what we need for chuck |
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3544/docs/iroh/ Last updated: 2025-10-21T11:07:04Z |
|
added |
| #[clap(long)] | ||
| remote_relay_url: Option<RelayUrl>, | ||
| #[clap(long)] | ||
| remote_direct_address: Vec<SocketAddr>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remote_direct_addr :)
|
|
|
Netsim is now passing https://github.com/n0-computer/iroh/actions/runs/18645720236/job/53255016686 We will need to coordinate the merges around these not to screw up other PRs |
…` options in the transfer example
5a43125 to
3e33c91
Compare
|
At the time of writting https://docs.rs/iroh/latest/iroh/discovery/static_provider/struct.StaticProvider.html still mentions and links (broken) to EndpointTicket. |
Thanks, fix here: #3814 |
Description
These now live in https://github.com/n0-computer/iroh-tickets and will be published as
iroh-tickets.Breaking Changes
iroh-base::tickethas been removedNotes
The
0rttandtransferexamples now use justEndpointIds to connect, and not tickets anymore. Otherwise we end up in a problematic dependency tree. If necessary I can add direct addresses and relay urls to thetransferexample again