Skip to content

test: Add test that common fields macro fails when used with a unit case #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

rklaehn
Copy link
Collaborator

@rklaehn rklaehn commented May 5, 2025

It should only work for (possibly empty) struct cases

Unfortunately these compile fail tests are very fragile. But what can you do?

It should only work for (possibly empty) struct cases
@rklaehn rklaehn requested a review from matheus23 May 5, 2025 08:25
@rklaehn
Copy link
Collaborator Author

rklaehn commented May 5, 2025

For some reason this was already failing. Maybe I messed up changing this after publishing.

@matheus23 can you check that it properly fails with this version, then I will publish it.

Copy link
Member

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep can confirm this works as expected 👍

@rklaehn rklaehn merged commit 8a430d9 into main May 5, 2025
1 check passed
@rklaehn rklaehn deleted the fail-unit-case branch May 5, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants