Skip to content

Conversation

rklaehn
Copy link
Collaborator

@rklaehn rklaehn commented Jul 2, 2025

A lot of changes, but most of them are related to progress bars.

Another important thing is to make sure shutdown is called in every case. If you stop the process before calling shutdown, the very last write might not be conserved, and you will end up re-requesting that chunk on next try.

@rklaehn rklaehn requested a review from ramfox July 2, 2025 08:16
@n0bot n0bot bot added this to iroh Jul 2, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Jul 2, 2025
@rklaehn rklaehn requested a review from Frando July 3, 2025 09:39
Copy link
Member

@ramfox ramfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also tested it locally.

@rklaehn rklaehn merged commit 2bed36f into main Jul 4, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Jul 4, 2025
@rklaehn rklaehn deleted the new-blobs branch July 4, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants