Support short-hand partial rendering syntax #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Just noticed there's another PR open (#13) that has some big changes. If you were going to merge both these in, I'd suggest mine first since it would be a lot easier. |
|
This is very useful. |
Owner
|
@swalkinshaw Sorry, can you update the Readme in this pull request so it merges cleanly. I inadvertently merged in another pull request that also added some changes to the Readme for highlighting. |
Before: required syntax for rendering was: `render partial: 'partial_name', collection: @collection, cache: true` After: `render @collection, cache: true` works as well. `cache: false` also disables caching as well now.
Contributor
Author
|
No problem. That highlighting fix was actually better since it used |
n8
pushed a commit
that referenced
this pull request
Mar 24, 2013
Support short-hand partial rendering syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a few things, but mainly adds support for short-hand partial rendering.
Before, only the following syntax was supported:
Now, this is also supported:
Few other minor changes:
is_a?(Proc)torespond_to?(:call)for a bit more flexibility.cache: falsefor easy collection caching toggling.Let me know if you want any of these extra commits removed.