Skip to content

feat(chart): add podLabels for extra labels on pod templates #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gkarach-conifers wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(chart): add podLabels for extra labels on pod templates #119

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96b2eed
feat(chart): add podLabels for extra labels on pod templates
Apr 26, 2026
0271c21
fix(chart): reject podLabels that overlap chart-managed selector keys
Apr 26, 2026
a484043
fix(chart): validate podLabels values are strings
Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/n8n/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ To use the namespace's default ServiceAccount, set `name: ""`. If you set `creat
| `ingress.enabled` | Create Ingress resource | `false` |
| `persistence.enabled` | PVC for main pods | `false` |
| `strategy` | Deployment update strategy | `{}` (k8s default) |
| `podLabels` | Extra labels on every pod template | `{}` |
| `hpa.main.enabled` | HPA for main pods | `false` |
| `hpa.worker.enabled` | HPA for worker pods | `false` |
| `keda.enabled` | KEDA queue-based autoscaling | `false` |
Expand Down
3 changes: 3 additions & 0 deletions charts/n8n/templates/deployment-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ spec:
labels:
{{- include "n8n.labels" . | nindent 8 }}
app.kubernetes.io/component: main
{{- with .Values.podLabels }}
{{- toYaml . | nindent 8 }}
Comment thread
gkarach-conifers marked this conversation as resolved.
{{- end }}
spec:
{{- with include "n8n.serviceAccountName" . }}
serviceAccountName: {{ . }}
Expand Down
3 changes: 3 additions & 0 deletions charts/n8n/templates/deployment-webhook-processor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ spec:
labels:
{{- include "n8n.labels" . | nindent 8 }}
app.kubernetes.io/component: webhook-processor
{{- with .Values.podLabels }}
{{- toYaml . | nindent 8 }}
Comment thread
gkarach-conifers marked this conversation as resolved.
{{- end }}
spec:
{{- with include "n8n.serviceAccountName" . }}
serviceAccountName: {{ . }}
Expand Down
3 changes: 3 additions & 0 deletions charts/n8n/templates/deployment-worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ spec:
labels:
{{- include "n8n.labels" . | nindent 8 }}
app.kubernetes.io/component: worker
{{- with .Values.podLabels }}
{{- toYaml . | nindent 8 }}
Comment thread
gkarach-conifers marked this conversation as resolved.
{{- end }}
spec:
{{- with include "n8n.serviceAccountName" . }}
serviceAccountName: {{ . }}
Expand Down
9 changes: 9 additions & 0 deletions charts/n8n/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,15 @@ taskRunners:
# to avoid Multi-Attach errors during upgrades.
strategy: {}

# ----- Pod Labels -----
# Extra labels added to the main / worker / webhook-processor pod templates,
# in addition to the chart's own selector labels. Useful for opt-in admission
# webhooks (e.g. Azure AD Workload Identity's `azure.workload.identity/use=true`,
# Istio's `sidecar.istio.io/inject=true`) and external scrape selectors.
# podLabels:
# azure.workload.identity/use: "true"
podLabels: {}

# ----- Main replicas (when multi-main is disabled) -----
replicaCount: 1

Expand Down