Port to Julia 0.7/1.0 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
commented
Sep 5, 2018
test/freqtable.jl
Outdated
| @@ -24,24 +24,24 @@ pt = @inferred prop(tab) | |||
| 0.075 0.05 0.05 0.075; | |||
| 0.05 0.075 0.075 0.05; | |||
| 0.05 0.075 0.075 0.05] | |||
| pt = @inferred prop(tab, 2) | |||
There was a problem hiding this comment.
We should find the origin of the inference regression so that we can keep these checks.
Closed
Use the new Name wrapper from NamedArrays 0.9.0 when indexing to avoid ambiguity with Integer names.
nalimilan
commented
Sep 5, 2018
| @@ -214,14 +215,13 @@ julia> sum(pt, (1, 2)) | |||
|
|
|||
| ``` | |||
| """ | |||
|
|
|||
| prop(tbl::AbstractArray{<:Number}) = tbl / sum(tbl) | |||
|
|
|||
| function prop(tbl::AbstractArray{<:Number,N}, margin::Integer...) where N | |||
There was a problem hiding this comment.
We should decide whether margin should become a keyword argument, and if yes whether we should keep this name.
There was a problem hiding this comment.
Good point - maybe dims as keyword argument?
There was a problem hiding this comment.
Yeah, maybe. However, the meaning is a bit different, and indeed the argument isn't passed to dims as-is. Maybe that's not an issue though.
There was a problem hiding this comment.
We can always fix it later as it is non breaking.
This was referenced Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new
Namewrapper from NamedArrays 0.9.0 when indexing to avoid ambiguity withIntegernames.Currently blocked by davidavdav/NamedArrays.jl#73.
Fixes #27.