fix(cicd-appimage): disable until it is fixed

namecheap · Aug 17, 2023 · eb89ab7 · eb89ab7
1 parent 0bab846
commit eb89ab7
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/.github/workflows/Linux-pack.yml b/.github/workflows/Linux-pack.yml
@@ -23,6 +23,7 @@ env:
   PACKPACK_REPO: flameshot-org/packpack
   # available upload services: wetransfer.com, file.io, 0x0.st
   UPLOAD_SERVICE: wetransfer.com
+  APPIMAGE_PACK_ENABLE: false
 
 jobs:
   deb-pack:
@@ -329,6 +330,7 @@ jobs:
 
   appimage-pack:
     name: Build appimage on ${{ matrix.config.name }}
+    if: ${{ APPIMAGE_PACK_ENABLE != "false" }}
     runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
@@ -400,7 +402,6 @@ jobs:
             ca-certificates \
             jq
 
-
       - name: Get go-appimage tool
       # Will not use linuxdeployqt anymore, because it suopprts currently still-supported mainstream distribution,
       # which is glibc 2.23. For more information, please see https://github.com/probonopd/linuxdeployqt/issues/340.
@@ -413,32 +414,33 @@ jobs:
           APPIMAGETOOL_ARCH: x86_64
       - name: Packaging appimage
         run: |
-          APPIMAGE_DST_PATH=$GITHUB_WORKSPACE/${PRODUCT}.AppDir
-          mkdir -p ${APPIMAGE_DST_PATH}
+          set -x
+          APPIMAGE_DST_PATH="$GITHUB_WORKSPACE/${PRODUCT}.AppDir"
+          mkdir -p "${APPIMAGE_DST_PATH}"
 
           cd $GITHUB_WORKSPACE
-          cmake -S -B build -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=/usr/"${APPIMAGE_DST_PATH}" -DUSE_LAUNCHER_ABSOLUTE_PATH:BOOL=OFF
+          cmake -S . -B build -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX="/usr/${APPIMAGE_DST_PATH}" -DUSE_LAUNCHER_ABSOLUTE_PATH:BOOL=OFF
           cmake --build build --target install --config RelWithDebInfo -- -j$(nproc)
 
 
-          $GITHUB_WORKSPACE/appimagetool -s deploy ${APPIMAGE_DST_PATH}/usr/share/applications/org.flameshot.Flameshot.desktop
+          $GITHUB_WORKSPACE/appimagetool -s deploy "${APPIMAGE_DST_PATH}/usr/share/applications/org.flameshot.Flameshot.desktop" "${APPIMAGE_DST_PATH}"
 
-          mkdir -p ${APPIMAGE_DST_PATH}/usr/plugins/platforminputcontexts
+          mkdir -p "${APPIMAGE_DST_PATH}/usr/plugins/platforminputcontexts"
           cp \
             /usr/lib/x86_64-linux-gnu/qt5/plugins/platforminputcontexts/libfcitxplatforminputcontextplugin.so \
-            ${APPIMAGE_DST_PATH}/usr/plugins/platforminputcontexts/
+            "${APPIMAGE_DST_PATH}/usr/plugins/platforminputcontexts/"
 
           cp \
             $GITHUB_WORKSPACE/data/img/app/org.flameshot.Flameshot.png \
-            ${APPIMAGE_DST_PATH}/
+            "${APPIMAGE_DST_PATH}"/ 
 
           if [ -f "${APPIMAGE_DST_PATH}/lib/x86_64-linux-gnu/libxcb-glx.so.0" ]; then
-            rm ${APPIMAGE_DST_PATH}/lib/x86_64-linux-gnu/libxcb-glx.so.0
+            rm "${APPIMAGE_DST_PATH}/lib/x86_64-linux-gnu/libxcb-glx.so.0"
           fi
 
-          chmod +x ${APPIMAGE_DST_PATH}/usr/lib64/ld-*.so.*
+          chmod +x "${APPIMAGE_DST_PATH}/usr/lib64/ld-*.so.*"
 
-          VERSION=${VERSION} $GITHUB_WORKSPACE/appimagetool ${APPIMAGE_DST_PATH}
+          VERSION=${VERSION} $GITHUB_WORKSPACE/appimagetool "${APPIMAGE_DST_PATH}"
           mv $GITHUB_WORKSPACE/Flameshot-${VERSION}-x86_64.AppImage $GITHUB_WORKSPACE/Flameshot-${VERSION}.x86_64.AppImage
       - name: SHA256Sum of appimage package(daily build)
         run: |