Add schema for the 1st SVOM notices (ECLAIRs, GRM & MXT)#245
Conversation
Vidushi-GitHub
left a comment
Vidushi-GitHub
left a comment
There was a problem hiding this comment.
Looks neat.
As discussed, please feel free to use "notice_type" with "enum", when you are producing multiple notices with the use of one schema.
| "$schema": true, | ||
| "slew_status": { | ||
| "enum": ["accepted", "rejected", "not_requested"], | ||
| "description": "Whether the platform accepted or rejected a slew requested by ECLAIRs (to its best localisation). If the detection is not significant enough, this value can remain to 'not_requested'" |
There was a problem hiding this comment.
| "description": "Whether the platform accepted or rejected a slew requested by ECLAIRs (to its best localisation). If the detection is not significant enough, this value can remain to 'not_requested'" | |
| "description": "Whether the platform accepted or rejected a slew requested by ECLAIRs (to its best localisation). If the detection is not significant enough, this value is 'not_requested'." |
There was a problem hiding this comment.
Is there a simple prescription for the significance or a document you can reference where it's described?
Vidushi-GitHub
left a comment
Vidushi-GitHub
left a comment
There was a problem hiding this comment.
Please replace localisation word to localization for consistency.
If you feel users may need different topics for eclairs catalog and slewing, please feel free to make different schemas.
To me rest of the stuff looks good to proceed.
| "alert_tense": "current", | ||
| "alert_type": "initial", | ||
| "alert_datetime": "2024-02-22T08:51:55", | ||
| "id": ["sb24022203"], |
There was a problem hiding this comment.
Please use as a single string, not array for single array, core schema is upgraded.
3 participants
This PR introduce the SVOM notices in the common JSON format used by the NASA/GCN system.
It replaces the json schemas previously defined for SVOM notices as it was too complicated. Instead we simplify it by defining 3 schemas based on the SVOM instruments. Different notice examples are also included to illustrates the different notice subtypes.