RC v1.4.0 #448
Merged
RC v1.4.0 #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
==========================================
- Coverage 83.51% 74.99% -8.53%
==========================================
Files 39 80 +41
Lines 11074 23341 +12267
Branches 835 1872 +1037
==========================================
+ Hits 9249 17505 +8256
- Misses 1518 5168 +3650
- Partials 307 668 +361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
|
Confirming this is the commit that JPL has been testing with? @Donnie-Ice |
jlucas9
approved these changes
Apr 25, 2025
dccutrig
approved these changes
Apr 25, 2025
They were testing from |
rjbrown2
reviewed
Apr 25, 2025
| @@ -67,34 +67,6 @@ void Crypto_tmPrint(TM_t *tm_frame) | |||
| printf("Current TM in memory is: \n"); | |||
There was a problem hiding this comment.
What is going on in this print statement. Should we just remove it entirely at this point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Candidate 1.4.0
https://github.com/nasa/CryptoLib/releases/tag/v1.4.0