-
Notifications
You must be signed in to change notification settings - Fork 47
471 return tm aos structs #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #472 +/- ##
==========================================
+ Coverage 81.19% 81.35% +0.16%
==========================================
Files 39 39
Lines 12235 12529 +294
Branches 1053 1086 +33
==========================================
+ Hits 9934 10193 +259
- Misses 1905 1925 +20
- Partials 396 411 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I pulled the memory leak fixes into this, so the PR is much larger than it should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks fine, pulled and built - all tests ran. We probably need to update standalone as part of this, and likely need to mention this again at JPL Weekly, although maybe not an entire code walk through. Food for thought - do we have integration tests that we can use with standalone? Should we?
|
After discussion yesterday don't need standalone in this PR since CL is a submodule of NOS. Approved! |
Modify SADB calls to work with 1 or 3 tables
All Submissions:
New Feature Submissions:
Changes to Core Features:
How do you test these changes?