Skip to content

Fixed unit-test/sc_loads_tests.c for the address-sanitizer #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
myc-yang wants to merge 1 commit into
base: draco-rc5-eval
Choose a base branch
from
Open

Fixed unit-test/sc_loads_tests.c for the address-sanitizer #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions unit-test/sc_loads_tests.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ void SC_LoadAts_Test_AtsEntryOverflow(void)
{
SC_AtsEntryHeader_t *Entry;
SC_AtsInfoTable_t AtsInfoTbl;
uint32 AtsTable[SC_ATS_BUFF_SIZE32];
uint32 Big_AtsTable[SC_ATS_BUFF_SIZE32 * 2];
Copy link
Copy Markdown
Contributor

@dzbaker dzbaker Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the rationale for doubling the table size?

Copy link
Copy Markdown
Author

@myc-yang myc-yang Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there was a specific rationale for doubling it. I just wanted to make sure it was big enough to prevent an overflow.

uint8 AtsIndex = 0;
size_t MsgSize1;
size_t MsgSize2;
Expand All @@ -423,12 +423,12 @@ void SC_LoadAts_Test_AtsEntryOverflow(void)
int j;

memset(&AtsInfoTbl, 0, sizeof(AtsInfoTbl));
memset(&AtsTable, 0, sizeof(AtsTable));
memset(&Big_AtsTable, 0, sizeof(Big_AtsTable));

SC_InitTables();

SC_OperData.AtsCmdStatusTblAddr[AtsIndex] = &SC_APP_TEST_GlobalAtsCmdStatusTbl[0];
SC_OperData.AtsTblAddr[AtsIndex] = &AtsTable[0];
SC_OperData.AtsTblAddr[AtsIndex] = &Big_AtsTable[0];
SC_OperData.AtsInfoTblAddr = &AtsInfoTbl;

MsgSize1 = SC_PACKET_MAX_SIZE;
Expand Down