Repository navigation
EDD-84: Fixing snyk issues - #79
Merged
Merged
Conversation
mandyparson
requested review from
cgokey,
eudoroolivares2016,
htranho,
macrouch and
stephenkilbourn
July 22, 2026 17:02
eudoroolivares2016
approved these changes
Jul 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 121 121
Lines 2504 2504
Branches 495 496 +1
=======================================
Hits 2395 2395
Misses 109 109 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
electron-updater is used in the application to check for updates to the app. this update should trigger a new app version so the running code is updated |
macrouch
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Resolve the snyk vulnerabilities on the project https://app.snyk.io/org/esdis-cumulus-core-gibs-cmr-etc./project/a8adc8b1-d7ce-40ee-b43d-c7944df23e3a
What is the Solution?
Upgrade electron-updater@6.6.2 to electron-updater@6.8.9 to fix
✗ Insertion of Sensitive Information Into Sent Data (new) [High Severity]
After that we were still sitting at 32 vulnerabilities (1 low, 19 moderate, 9 high, 3 critical) ran npm audit fix got it down to 20 vulnerabilities (17 moderate, 1 high, 2 critical)
I ran a depcheck and discovered several unused dependencies that were causing some of the issues above. I uninstalled the ones that I doubled checked were not being used anywhere in the repo: npm uninstall undici nyc jest-junit
nyc is a code coverage tool that it appears we used at one point. Jest covers all the use cases nyc was for so I deleted the old files that weren't being used as well.
After making those changes we are now at 16 vulnerabilities (14 moderate, 2 critical). There are no fixes available for the critical vulnerabilities at this time.
What areas of the application does this impact?
package.json and associated nyc files
Testing
Reproduction steps
Attachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Checklist
versionfield in package.json and rannpm install