Skip to content

EDD-84: Need to create workaround for github actions - #81

Merged
mandyparson merged 6 commits into
mainfrom
EDD-84-2
Jul 27, 2026
Merged

mandyparson merged 6 commits into
mainfrom
EDD-84-2

Conversation

@mandyparson

Copy link
Copy Markdown
Member

Overview

What is the feature?

I ran into an issue with pushing up the release version. When the application went to build, I received this error message: https://github.com/nasa/earthdata-download/actions/runs/30023021665

“Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/setup-node@v4, macrouch/action-electron-builder@v1.6.1. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners[/](https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/)“

What is the Solution?

This ticket implements a temporary workaround (ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true) in build.yml to keep our releases functioning, but this workaround will stop working in Fall 2026 when GitHub removes Node 20 completely.

A follow on ticket has been created here: https://bugs.earthdata.nasa.gov/browse/EDD-90 to address the underlying issue.

What areas of the application does this impact?

build.yml

Testing

Reproduction steps

  • Environment for testing:
  • Collection to test with:

N/A

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have bumped the version field in package.json and ran npm install

@codecov

codecov Bot commented Jul 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.64%. Comparing base (2cff35e) to head (288e369).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files         121      121           
  Lines        2504     2504           
  Branches      496      495    -1     
=======================================
  Hits         2395     2395           
  Misses        109      109           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@macrouch macrouch left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That node warning is only a warning, not an error. Looking at the actual error from the build, this will not fix it.

I think the fix you need is updating better-sqlite3 and maybe node-abi, but you should do test builds to ensure it works

Comment thread package.json Outdated
{
"name": "earthdata-download",
"version": "1.0.9",
"version": "1.0.10",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You never released 1.0.9, this doesn't need to change

@mandyparson

Copy link
Copy Markdown
Member Author

@macrouch I updated those two packages. Few things:

  1. I can't get a download to work. It just spins endlessly. I'm assuming that's because we haven't made the release yet and main is technically on 1.0.9? When I tested it before I sent up the change, the downloads worked fine.
  2. In the error logs it says: C:\Windows\system32\cmd.exe Error: Could not find any Visual Studio installation to use. So this is failing on the Windows build which I can't reproduce on my local machine. Is there any other way you think of that I can reproduce the issue locally?

@mandyparson
mandyparson requested a review from macrouch July 24, 2026 19:34
Comment thread .github/workflows/build.yml Outdated

# TODO: Remove in EDD-90
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

@eudoroolivares2016 eudoroolivares2016 Jul 27, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the core issue was just the windows version + the update to the forked macrouch/action-electron-builder@9aea484

and that bumps it up to node24 is this still needed? The actual app should be targeting node24

@macrouch macrouch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming you got a successful test release from the updated electron builder action?

@eudoroolivares2016 eudoroolivares2016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to download the draft release on my windows machine

@mandyparson
mandyparson merged commit e70a943 into main Jul 27, 2026
12 checks passed
@mandyparson
mandyparson deleted the EDD-84-2 branch July 27, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants