Repository navigation
EDD-84: Need to create workaround for github actions - #81
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 121 121
Lines 2504 2504
Branches 496 495 -1
=======================================
Hits 2395 2395
Misses 109 109 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| { | ||
| "name": "earthdata-download", | ||
| "version": "1.0.9", | ||
| "version": "1.0.10", |
There was a problem hiding this comment.
You never released 1.0.9, this doesn't need to change
|
@macrouch I updated those two packages. Few things:
|
|
|
||
| # TODO: Remove in EDD-90 | ||
| env: | ||
| ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true |
There was a problem hiding this comment.
Since the core issue was just the windows version + the update to the forked macrouch/action-electron-builder@9aea484
and that bumps it up to node24 is this still needed? The actual app should be targeting node24
macrouch
left a comment
There was a problem hiding this comment.
Looks good, assuming you got a successful test release from the updated electron builder action?
eudoroolivares2016
left a comment
There was a problem hiding this comment.
I was able to download the draft release on my windows machine
Overview
What is the feature?
I ran into an issue with pushing up the release version. When the application went to build, I received this error message: https://github.com/nasa/earthdata-download/actions/runs/30023021665
“Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/cache@v4, actions/checkout@v4, actions/setup-node@v4, macrouch/action-electron-builder@v1.6.1. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners[/](https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/)“
What is the Solution?
This ticket implements a temporary workaround (ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true) in build.yml to keep our releases functioning, but this workaround will stop working in Fall 2026 when GitHub removes Node 20 completely.
A follow on ticket has been created here: https://bugs.earthdata.nasa.gov/browse/EDD-90 to address the underlying issue.
What areas of the application does this impact?
build.yml
Testing
Reproduction steps
N/A
Attachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Checklist
versionfield in package.json and rannpm install