Conversation
macrouch
requested review from
eudoroolivares2016,
mandyparson,
stephenkilbourn,
trevorlang and
william-valencia
Bundle Size ComparisonFull build detailsThe full bundle is smaller than main by 0 kB. 🎉 The index.js is smaller than main by 0 kB. 🎉 Run
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2066 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 755 755
Lines 17563 17563
Branches 4939 4935 -4
=======================================
Hits 16811 16811
Misses 700 700
Partials 52 52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
eudoroolivares2016
approved these changes
Jul 2, 2026
mandyparson
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Switch from Redis to Valkey
What is the Solution?
Updated infrastructure stack to add a new Valkey cache. Leaving the existing Redis cache for now, wrote a future ticket to remove it. We can't remove it because stack output variables are being used in the application stack.
Moved from async-redis to ioredis client library. Both are compatible with Valkey, but ioredis is used a lot more and more maintained.
I tested using
@valkey/valkey-glide, but did not have luck getting it working with our local environment or the build process.What areas of the application does this impact?
Scaled images, nlp search
Testing
To switch to Valkey locally (if using homebrew)
To verify valkey cache works with scaleImage lambda:
npm run start:optionalsChecklist