Review recommendations - pt 1

Svc/TlmPacketizer/TlmPacketizer.cpp

@@ -59,9 +59,8 @@
     // table
     for (FwChanIdType pktEntry = 0; pktEntry < packetList.numEntries; pktEntry++) {
         // Initial size is packetized telemetry descriptor + size of time tag + sizeof packet ID
-        //TODO: do I add a check here
         FwSizeType packetLen =
             sizeof(FwPacketDescriptorType) + Fw::Time::SERIALIZED_SIZE + sizeof(FwTlmPacketizeIdType);
         FW_ASSERT(packetList.list[pktEntry]->list, static_cast<FwAssertArgType>(pktEntry));
         // add up entries for each defined packet
         for (FwChanIdType tlmEntry = 0; tlmEntry < packetList.list[pktEntry]->numEntries; tlmEntry++) {
@@ -85,7 +84,7 @@
         FW_ASSERT(packetLen <= FW_COM_BUFFER_MAX_SIZE, static_cast<FwAssertArgType>(packetLen), static_cast<FwAssertArgType>(pktEntry));
         // clear contents
         memset(this->m_fillBuffers[pktEntry].buffer.getBuffAddr(), 0, static_cast<size_t>(packetLen));
         // serialize packet descriptor and packet ID now since it will always be the same
         Fw::SerializeStatus stat = this->m_fillBuffers[pktEntry].buffer.serialize(
             static_cast<FwPacketDescriptorType>(Fw::ComPacket::FW_PACKET_PACKETIZED_TLM));
         FW_ASSERT(Fw::FW_SERIALIZE_OK == stat, stat);
@@ -131,7 +130,7 @@
 
 TlmPacketizer::TlmEntry* TlmPacketizer::findBucket(FwChanIdType id) {
     FwChanIdType index = this->doHash(id);
     FW_ASSERT(index < TLMPACKETIZER_HASH_BUCKETS);
     TlmEntry* entryToUse = nullptr;
     TlmEntry* prevEntry = nullptr;
 
@@ -190,7 +189,7 @@
     FW_ASSERT(this->m_configured);
     // get hash value for id
     FwChanIdType index = this->doHash(id);
     TlmEntry* entryToUse = nullptr;
 
     // Search to see if the channel is being sent
     entryToUse = this->m_tlmEntries.slots[index];