Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 233 sorting variable arg in cli #238

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Sep 6, 2024

GitHub Issue: #233

Description

Renamed time_variable to sorting_variable to better reflect its purpose. Exposed this variable in the CLI, and moved the default for TEMPO into the Harmony adapter and out of the stitchee core code.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://stitchee--238.org.readthedocs.build/en/238/

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.02%. Comparing base (0e53d8f) to head (cf9b31d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #238      +/-   ##
===========================================
+ Coverage    83.46%   86.02%   +2.56%     
===========================================
  Files           11       11              
  Lines          641      644       +3     
===========================================
+ Hits           535      554      +19     
+ Misses         106       90      -16     
Flag Coverage Δ
integration 45.03% <75.00%> (?)
unittests 83.54% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth marked this pull request as ready for review September 6, 2024 19:33
@danielfromearth danielfromearth self-assigned this Sep 6, 2024
@danielfromearth danielfromearth added the enhancement New feature or request label Sep 6, 2024
@danielfromearth danielfromearth merged commit 6b667d4 into develop Sep 6, 2024
5 checks passed
@danielfromearth danielfromearth deleted the feature/issue-233-time-variable-arg-in-cli branch September 6, 2024 20:24
@danielfromearth danielfromearth linked an issue Oct 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose sorting variable argument in the command line interface
2 participants