Fix C# property resolution in shortcuts #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fireye04
changed the title
Contributor
Author
|
Ok double checking the enum thing, it looks like before the changes you get the enum number routed through but after it just nulls. |
Fireye04
force-pushed
the
patch/property-fix
branch
from
d3ee2df to
ef58e23
Compare
nathanhoad
force-pushed
the
patch/property-fix
branch
from
ef58e23 to
4706119
Compare
Contributor
Author
|
Ah, very sorry I couldn't get around to finishing this, appreciate the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #936
WIP. Currently fixes the bug and passes all tests, however still needs further testing, as there are almost certainly breaking edgecases. (I believe enum types are still breaking).
Feedback is welcome!