fix(tabs): fix weird behavior when disabling animations on tabstrip #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a weird scenario where when animations are disabled the tabstrip doesn't go to the correct position.
The reason for the complicated solution is that if you're midscroll the scrollstate will bug out on
2
and we'll receive an extraonPageScrolled
event, so we just forcefully change the tab and ignore the state until the scroll state changes (this ALWAYS changes when a scroll starts, even when in the bugged 2 state, goes either to 1 or 0);I've tested with this PR:
Very ugly, but gets the job done.