Skip to content

Conversation

@stardiviner
Copy link

Ask user for spoken language instead of always use the hardcoded whisper-language for user who will touch different languages content.

@natrys
Copy link
Owner

natrys commented May 20, 2024

Hi, thanks for this. I am sympathetic to needs of people who have to switch languages a lot, but I note that this will come at the UX cost where people who don't switch language often (who I presume are majority) will still have to choose (same) one every time. I think at least this needs to be behind a new variable (like whisper-always-ask-language).

But before that, I am curious, have you tried setting whisper-language to "auto"? This is supposed to auto detect language (and do a reasonably good job so long as we have a clip >30 seconds). Shouldn't that render manual setup unnecessary?

@stardiviner
Copy link
Author

I have tried the "auto", but I hope can reduce this delay time. You're right, we need to have another custom option like (setq whisper-always-ask-language nil) which nil by default. WDYT?

Controlled by new added custom option `whisper-always-ask-language`.
@stardiviner
Copy link
Author

I updated the patch, and put the whisper-language asking in let-binding to limit every change in function local scope without affect user custom option whisper-language value.

@natrys
Copy link
Owner

natrys commented May 22, 2024

Sorry, I am held up because all my headsets are dead so can't do any functional testing. Hopefully will get to it in a week.

@natrys natrys force-pushed the master branch 2 times, most recently from 826b11d to 6198ce3 Compare August 16, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants