add close! and reopen! to case #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenyu
approved these changes
Oct 23, 2025
baonguyenNava
approved these changes
Oct 23, 2025
| @@ -1,7 +0,0 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class RenameFlexTasksToStrataTasks < ActiveRecord::Migration[8.0] | |||
There was a problem hiding this comment.
The best way to remove this migration is to run make db-rollback with this file still here but line 5 commented out. That will update the schema file, then you can remove this file and commit it and the schema.
There was a problem hiding this comment.
oh I didn't think of the schema file , I will role it back first
There was a problem hiding this comment.
actually that does nothing other than update the version on the schema file and no other changes. the current scheam file and its version are valid this migration is superfluous so there is not reason to roll back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
add the close! and reopen! to the case model
Context
the close! and the reopen! methods are needed for instances where we need to raise exceptions on save!. This is useful when wrapping this call in a transactions.
Testing
referenced the updated gem in the oscar app and validated that functionality.