TEST: Add test for issue #655#828
Merged
jhpark816 merged 1 commit intonaver:developfrom Mar 27, 2025
Merged
Conversation
jhpark816
reviewed
Mar 25, 2025
| sub is_zombie { | ||
| my $pid = shift; | ||
| my $proc_state = `ps -p $pid -o stat=`; | ||
| return $proc_state =~ /^Z/ |
Collaborator
There was a problem hiding this comment.
1.13.1 버전에서 테스트가 원하는 대로 동작하나요?
Collaborator
Author
There was a problem hiding this comment.
네. 원하는 데로 동작합니다.
1..2
not ok 1 - bop insert bkey 0 6 create 0 1742947050 10:datum0
# Failed test 'bop insert bkey 0 6 create 0 1742947050 10:datum0'
# at /Users/jam2in/Documents/GitHub/arcus-memcached/t/lib/MemcachedTest.pm line 133.
# got: ''
# expected: 'CREATED_STORED'
not ok 2 - bop get bkey 0:
# Failed test 'bop get bkey 0:'
# at /Users/jam2in/Documents/GitHub/arcus-memcached/t/lib/MemcachedTest.pm line 133.
# got: ''
# expected: 'NOT_FOUND'
# Looks like you failed 2 tests of 2.
| mem_cmd_is($sock, $cmd, $val, $rst); | ||
|
|
||
| sleep(0.01); | ||
| ok(not is_zombie($server->{pid})); |
Collaborator
There was a problem hiding this comment.
이 방식 대신에 bop get 수행하면 되지 않나 생각됩니다.
결과는 NOT_FOUND이어야 하고요.
| ./t/issue_68.t | ||
| ./t/issue_70.t | ||
| ./t/issue_arcus_151.t | ||
| ./t/issue_arcus_655.t |
Collaborator
There was a problem hiding this comment.
655에 대한 이슈 link를 코멘트로 남겨주세요.
확인해 보고자 합니다.
Collaborator
There was a problem hiding this comment.
#655 는 PR 입니다.
이슈는 jam2in/arcus-works#357 인데, naver/arucs-memcached의 이슈가 아니라서 655 PR으로 대체한 것이 아닌가 싶습니다.
jhpark816
reviewed
Mar 26, 2025
| my $server = get_memcached($engine); | ||
| my $sock = $server->sock; | ||
|
|
||
| my $expire = time() - 1; |
Collaborator
There was a problem hiding this comment.
아래와 같이 주석을 달 수 있다면 주석을 추가하시죠.
my $expire = time() - 1; // immediate expiration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did