Skip to content

DOC: Update Changelog format#829

Merged
jhpark816 merged 1 commit intonaver:developfrom
namsic:changelog
Mar 31, 2025
Merged

DOC: Update Changelog format#829
jhpark816 merged 1 commit intonaver:developfrom
namsic:changelog

Conversation

@namsic
Copy link
Copy Markdown
Collaborator

@namsic namsic commented Mar 31, 2025

🔗 Related Issue

  • jam2in/arcus-works#708

⌨️ What I did

  • Changelog 형식을 수정합니다.

Comment thread ChangeLog Outdated
# 2024-01-17 [version 1.13.5]
## 🐣 New Features
* Add `ready` command Add ready command to verify that the cache server can receive requests. In Zookeeper clustering, the cache node becomes ready state after creating its cache_list znode. #707
- Add `ready` command Add ready command to verify that the cache server can receive requests. In Zookeeper clustering, the cache node becomes ready state after creating its cache_list znode. #707
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 두 line으로 분리할까요?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예 다른 line으로 분리합시다.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문장 단위로 2개 line으로 구분했더니 여전히 긴 것 같아서,
다른 변경사항과 비슷한 길이가 되도록 3개 line으로 분리했습니다.

추가로, deps 관련 변경사항도 line을 나누었습니다.

 - Modify to have dependency libraries(libevent and zookeeper-client-c) and
     add dependency libraries install script.

Copy link
Copy Markdown
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

Comment thread ChangeLog Outdated
* Add `ready` command Add ready command to verify that the cache server can receive requests. In Zookeeper clustering, the cache node becomes ready state after creating its cache_list znode. #707
- Add `ready` command Add ready command to verify that the cache server
can receive requests. In Zookeeper clustering, the cache node becomes
ready state after creating its cache_list znode. #707
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 indentation 맞추시죠.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

long line인 경우 multi-line 형식이 모든 viewer에서 동일하게 잘 보이는 거죠?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vi에서만 잘 보이면 나머지 에디터/뷰어에서도 크게 문제 없다고 보시면 됩니다.

@jhpark816 jhpark816 merged commit 340ed2b into naver:develop Mar 31, 2025
1 check passed
@namsic namsic deleted the changelog branch March 31, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants