INTERNAL: Rename DO_UPDATE to LRU_UPDATE#830
Closed
ing-eoking wants to merge 1 commit intonaver:developfrom
Closed
INTERNAL: Rename DO_UPDATE to LRU_UPDATE#830ing-eoking wants to merge 1 commit intonaver:developfrom
ing-eoking wants to merge 1 commit intonaver:developfrom
Conversation
jhpark816
reviewed
Apr 11, 2025
| /* A lru_update argument value representing that | ||
| * we should check and reposition items in the LRU list. | ||
| */ | ||
| #define DO_UPDATE true |
Collaborator
There was a problem hiding this comment.
DO_UPDATE만 변경하고, DONT_UPDATE는 변경하지 않았네요.
어떤 용어가 좋은 지를 제시하고,
한꺼번에 변경하는 것이 일관성이 있을 것입니다.
Collaborator
Author
There was a problem hiding this comment.
아래의 용어가 좋은 것 같습니다.
LRU_SKIPLRU_READONLY
Collaborator
There was a problem hiding this comment.
DO_UPDATE는 LRU_UPDATE로 변경하고,
DONT_UPDATE 대신에 LRU_SKIP or LRU_READONLY가 좋다는 의견인가요?
Collaborator
There was a problem hiding this comment.
매크로 상수 두지 않고 true / false 직접 사용하면 안 되나요?
Collaborator
|
@ing-eoking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did