Skip to content

DOCS: Set unstable version to ChangeLog#832

Merged
jhpark816 merged 1 commit intonaver:developfrom
namsic:changelog
Apr 12, 2025
Merged

DOCS: Set unstable version to ChangeLog#832
jhpark816 merged 1 commit intonaver:developfrom
namsic:changelog

Conversation

@namsic
Copy link
Copy Markdown
Collaborator

@namsic namsic commented Apr 11, 2025

🔗 Related Issue

  • jam2in/arcus-works#472
  • jam2in/arcus-works#703

⌨️ What I did

  • ChangeLog에 unstable version 관련 내용을 추가합니다.

@namsic namsic requested a review from jhpark816 April 11, 2025 05:10
Copy link
Copy Markdown
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

Comment thread ChangeLog Outdated

2022-11-28 [version 1.13.4]
2022-11-28 [version 1.13.4] - UNSTABLE
* [Unstable] Abnormal behavior when count is 0 in bop mget/smget
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tab 문자를 넣어야 합니다.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

질문이 있습니다.
smget도 해당이 되나요?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • jam2in/arcus-works#474

이슈 자체가 smget을 제목으로 하여 처리가 진행되었습니다.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old smget 연산이 문제되는가 봅니다.
따라서, smget 연산도 포함하는 것이 맞네요.

Comment thread ChangeLog Outdated
* [CLEANUP] refactored many parts in source code.
2021-10-26 [version 1.13.3] - UNSTABLE
* [Unstable] Abnormal behavior when an item expires before inserting
an element during collection insert with create option
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abnormal behavior when inserting an element while creating a collection that expires immediately

위의 문장이 낫지 않나 생각합니다.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.13.3에는 1.13.4에 있는 unstable 사항이 없는 상태인가요?
즉, 1.13.4에 있는 unstable 사항은 1.13.4에만 들어갔나요?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

형식은 아래와 같이 하면 좋겠습니다.
아래에서 이모지는 변경되어야 합니다.

# 2024-01-17 [version 1.13.5] - UNSTABLE
  . . . 

## ⬆️ Unstable Items
  - item 1
  - item 2



2021-10-26 [version 1.13.3] - UNSTABLE
    * [FIX] wrong parsing of delay option in flush_prefix command.
    * Unstable Items
      * item 1
      * item 2

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.13.3에는 1.13.4에 있는 unstable 사항이 없는 상태인가요?
즉, 1.13.4에 있는 unstable 사항은 1.13.4에만 들어갔나요?

아래 commit 반영된 후(1.12.1)부터 문제 발생하는 것으로 보입니다.

63e11a8#r155181962

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대부분이 unstable 버전이 되는군요.

Copy link
Copy Markdown
Collaborator Author

@namsic namsic Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

클라이언트 버전 등에 따라 문제가 되는 요청이 서버에 전달되지 않을 수 있고,
현재까지 실 서비스에서 이에 대한 문제가 생긴 적이 없는 관계로 아래와 같이 정리합니다.

  • 버전 옆 - UNSTABLE 표기는 하지 않음
  • 변경 사항 마지막 Unstable Item 항목에는 내용 작성
    (offset 인자와 함께 count를 0으로 설정하는 경우 문제 발생)

@jhpark816
Copy link
Copy Markdown
Collaborator

@namsic 리뷰하면 되죠?

@namsic namsic requested a review from jhpark816 April 11, 2025 13:20
@jhpark816 jhpark816 merged commit ea84cc1 into naver:develop Apr 12, 2025
1 check passed
@namsic namsic deleted the changelog branch April 12, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants