INTERNAL: Change some errors to INVALID#834
Open
ing-eoking wants to merge 1 commit intonaver:developfrom
Open
Conversation
namsic
reviewed
Apr 17, 2025
Collaborator
namsic
left a comment
There was a problem hiding this comment.
일부 admin 명령어는 INVALID로 변경했습니다.
shutdown을 제외한 DENIED를 반환하는 에러
shutdown을 제외하는 이유는 무엇인가요?
Collaborator
Author
통일성을 위해 "DENIED" 응답을 모두 "INVALID"로 변경하려고 했습니다. 그러나 shutdown 명령의 경우, 다른 에러들과는 다르게 특정 상황에서 해당 명령이 거부됨을 나타내기에 유지했습니다. |
Collaborator
|
@ing-eoking |
Collaborator
Author
|
@jhpark816 "CLIENT_ERROR bad value" 응답 메시지의 일부를 "INVALID"로 변경하는 방안에 대해 검토 중이지만, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
INVALID로 변경했습니다.too many prefixes와 관련된 에러ENGINE_EBADVALUE와 관련된 에러DENIED를 반환하는 에러