version 1.14.1#837
Merged
jhpark816 merged 1 commit intonaver:developfrom Jul 2, 2025
Merged
Conversation
jhpark816
reviewed
Jun 30, 2025
| - Fix response string when trimmed result in bop insert. | ||
| ## ✅ Testing | ||
| - Upgrade CI actions version (v3 => v4). | ||
|
|
Collaborator
There was a problem hiding this comment.
ChangeLog 포함 기준을 많이 높인 것 같은 데요.
그 기준을 조금 낮추어도 되는 지를 확인해 주세요.
Collaborator
Author
There was a problem hiding this comment.
stats prefix기능 제거도 추가해 두시죠.
릴리즈되지 않고 hubble-v3에서만 일시적으로 사용했던 기능이라 제외했었는데,
(Internal Changes로) 추가해 두었습니다.
- authenticated 플래그와
-S옵션은 의도적으로 제외하였나요?
마찬가지로 ascii sasl은 아직 충분히 구현되지 않은 상태라서 제외했는데,
필요하다고 판단하시면 추가하겠습니다.
jhpark816
reviewed
Jun 30, 2025
Collaborator
jhpark816
left a comment
jhpark816
left a comment
There was a problem hiding this comment.
추가할 부분을 확인하고 코멘트했습니다.
| @@ -1,3 +1,19 @@ | |||
| # 2025-06-30 [version 1.14.1] | |||
| ## 🐣 New Features | |||
| - Return random elements from `sop get`. | |||
Collaborator
There was a problem hiding this comment.
sop get count 제약을 추가합시다.
Collaborator
There was a problem hiding this comment.
authenticated 플래그와
-S 옵션은 의도적으로 제외하였나요?
| - Return random elements from `sop get`. | ||
| ## ⚙️ Internal Changes | ||
| - Add max_stats_prefixes limit to `stats prefix` command. | ||
| - Change DFS traverse order in set and map. |
Collaborator
There was a problem hiding this comment.
완전한 DFS 로직이 되도록 변경한 것이군요.
Collaborator
There was a problem hiding this comment.
stats prefix 기능 제거도 추가해 두시죠.
Collaborator
Author
sop get의 count 제한은 long request 방지 목적입니다. |
Collaborator
Author
|
jhpark816
approved these changes
Jul 2, 2025
Collaborator
|
@namsic 현 상태로 릴리즈하겠습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version commit