Skip to content

INTERNAL: Fix misleading status comment in btree_elem_item #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhpark816 merged 1 commit into from
Apr 9, 2026
Merged

INTERNAL: Fix misleading status comment in btree_elem_item #967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions engines/default/item_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ typedef struct _map_elem_item {
typedef struct _btree_elem_item_fixed {
uint16_t refcount;
uint8_t slabs_clsid; /* which slab class we're in */
uint8_t status; /* 3(used), 2(insert mark), 1(delete_mark), or 0(free) */
uint8_t status; /* element lifecycle state: used(in-tree), unlinked(removed but referenced), or free */
Copy link
Copy Markdown
Collaborator

@namsic namsic Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ—ค๋”์—์„œ ๊ฐ ๊ฐ’์˜ ์˜๋ฏธ๋ฅผ ๋“œ๋Ÿฌ๋‚ด์ง€ ์•Š๊ณ , status ํ•„๋“œ์˜ ์šฉ๋„๋งŒ ์„ค๋ช…ํ•˜์‹œ์ฃ .

์ดํ›„์— status ๊ฐ’์˜ ์˜๋ฏธ๊ฐ€ ๋ณ€๊ฒฝ๋  ๊ฐ€๋Šฅ์„ฑ์€ ๋‚ฎ์ง€๋งŒ,
/* element lifecycle state */ ์ •๋„๋กœ๋งŒ ์ž‘์„ฑํ•ด๋‘๋ฉด ์ข‹๊ฒ ์Šต๋‹ˆ๋‹ค.

Copy link
Copy Markdown
Collaborator

@jhpark816 jhpark816 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ฐ ํ•„๋“œ ๊ฐ’์˜ ์˜๋ฏธ๋ฅผ ๋‘๋Š” ๊ฒƒ์ด ๊ดœ์ฐฎ์•„ ๋ณด์ž…๋‹ˆ๋‹ค.

uint8_t nbkey; /* length of bkey */
uint8_t neflag; /* length of element flag */
uint16_t nbytes; /**< The total size of the data (in bytes) */
Expand All @@ -208,7 +208,7 @@ typedef struct _btree_elem_item_fixed {
typedef struct _btree_elem_item {
uint16_t refcount;
uint8_t slabs_clsid; /* which slab class we're in */
uint8_t status; /* 3(used), 2(insert mark), 1(delete_mark), or 0(free) */
uint8_t status; /* element lifecycle state: used(in-tree), unlinked(removed but referenced), or free */
uint8_t nbkey; /* length of bkey */
uint8_t neflag; /* length of element flag */
uint16_t nbytes; /**< The total size of the data (in bytes) */
Expand Down
Loading