Los app #6543
Los app #6543
Conversation
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| msw: { | ||
| handlers: [ | ||
| http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)), | ||
| http.get(LosUrl.HENT_OPPGAVER_FOR_AVDELING.replace('ø', '%C3%B8'), () => |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 days ago
To fix the problem, we should ensure that all occurrences of 'ø' in the string are replaced with '%C3%B8', not just the first. The best way to do this is to use a regular expression with the global (g) flag: .replace(/ø/g, '%C3%B8'). This change should be made directly on line 57, replacing the current .replace('ø', '%C3%B8') with .replace(/ø/g, '%C3%B8'). No additional imports or definitions are needed, as this is standard JavaScript functionality.
| @@ -54,7 +54,7 @@ | ||
| msw: { | ||
| handlers: [ | ||
| http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)), | ||
| http.get(LosUrl.HENT_OPPGAVER_FOR_AVDELING.replace('ø', '%C3%B8'), () => | ||
| http.get(LosUrl.HENT_OPPGAVER_FOR_AVDELING.replace(/ø/g, '%C3%B8'), () => | ||
| HttpResponse.json(OPPGAVER_FOR_AVDELING), | ||
| ), | ||
| ], |
| msw: { | ||
| handlers: [ | ||
| http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)), | ||
| http.get(LosUrl.HENT_OPPGAVER_PER_DATO.replace('ø', '%C3%B8'), () => HttpResponse.json(OPPGAVER_PER_DATO)), |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 days ago
The best way to fix this problem is to ensure that all occurrences of 'ø' in the string are replaced, not just the first. This can be done by using a regular expression with the global flag: .replace(/ø/g, '%C3%B8'). However, since the intention is to encode a URL, the most robust and future-proof solution is to use the built-in encodeURI or encodeURIComponent functions, which handle all necessary character encodings for URLs. In this context, if the entire URL needs to be encoded, use encodeURI; if only a component (such as a path segment or query parameter), use encodeURIComponent. Since the code is replacing 'ø' with its percent-encoded form, it is likely that the intention is to encode the URL. Therefore, replace .replace('ø', '%C3%B8') with encodeURI(LosUrl.HENT_OPPGAVER_PER_DATO). This change should be made on line 65 of apps/los-avdelingsleder/src/nokkeltall/tilBehandling/TilBehandlingPanel.stories.tsx. No additional imports are needed, as encodeURI is a global JavaScript function.
| @@ -62,7 +62,7 @@ | ||
| msw: { | ||
| handlers: [ | ||
| http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)), | ||
| http.get(LosUrl.HENT_OPPGAVER_PER_DATO.replace('ø', '%C3%B8'), () => HttpResponse.json(OPPGAVER_PER_DATO)), | ||
| http.get(encodeURI(LosUrl.HENT_OPPGAVER_PER_DATO), () => HttpResponse.json(OPPGAVER_PER_DATO)), | ||
| ], | ||
| }, | ||
| }, |
No description provided.