-
Notifications
You must be signed in to change notification settings - Fork 5
Los app #6543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
...sleder/src/nokkeltall/fordelingAvBehandlingstype/FordelingAvBehandlingstypePanel.stories.tsx
Fixed
Show fixed
Hide fixed
apps/los-avdelingsleder/src/nokkeltall/tilBehandling/TilBehandlingPanel.stories.tsx
Fixed
Show fixed
Hide fixed
msw: { | ||
handlers: [ | ||
http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)), | ||
http.get(LosUrl.HENT_OPPGAVER_FOR_AVDELING.replace('ø', '%C3%B8'), () => |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 2 days ago
The problem should be fixed by ensuring all occurrences of the character ø
in the string are replaced with the percent-encoded value %C3%B8
. This is best accomplished using a regular expression with the global g
flag, such as .replace(/ø/g, '%C3%B8')
. Alternatively, the entire URL string could be encoded using encodeURI
or encodeURIComponent
(as appropriate), but if encoding only ø
is desired, use of the global regex is most targeted, does not risk double-encoding already encoded bytes, and matches the original behavior. Change only line 57 of apps/fp-avdelingsleder/src/nokkeltall/fordelingAvBehandlingstype/FordelingAvBehandlingstypePanel.stories.tsx to .replace(/ø/g, '%C3%B8')
. No new imports or definitions are needed.
-
Copy modified line R57
@@ -54,7 +54,7 @@ | ||
msw: { | ||
handlers: [ | ||
http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)), | ||
http.get(LosUrl.HENT_OPPGAVER_FOR_AVDELING.replace('ø', '%C3%B8'), () => | ||
http.get(LosUrl.HENT_OPPGAVER_FOR_AVDELING.replace(/ø/g, '%C3%B8'), () => | ||
HttpResponse.json(OPPGAVER_FOR_AVDELING), | ||
), | ||
], |
msw: { | ||
handlers: [ | ||
http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)), | ||
http.get(LosUrl.HENT_OPPGAVER_PER_DATO.replace('ø', '%C3%B8'), () => HttpResponse.json(OPPGAVER_PER_DATO)), |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 2 days ago
The best fix is to ensure that all occurrences of 'ø'
in the URL string are replaced with '%C3%B8'
, not just the first. This can be accomplished by passing a regular expression to .replace
with the global flag: .replace(/ø/g, '%C3%B8')
. If the value being URL-encoded can contain more than just 'ø'
, it’s even safer to use a standard encoding library such as encodeURIComponent
, but per the context, the code is just targeting 'ø'
. The fix is a one-line change: replace the call .replace('ø', '%C3%B8')
with .replace(/ø/g, '%C3%B8')
on line 65 within apps/fp-avdelingsleder/src/nokkeltall/tilBehandling/TilBehandlingPanel.stories.tsx
. No new imports are needed.
-
Copy modified line R65
@@ -62,7 +62,7 @@ | ||
msw: { | ||
handlers: [ | ||
http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)), | ||
http.get(LosUrl.HENT_OPPGAVER_PER_DATO.replace('ø', '%C3%B8'), () => HttpResponse.json(OPPGAVER_PER_DATO)), | ||
http.get(LosUrl.HENT_OPPGAVER_PER_DATO.replace(/ø/g, '%C3%B8'), () => HttpResponse.json(OPPGAVER_PER_DATO)), | ||
], | ||
}, | ||
}, |
|
No description provided.