ci: use recommended mobileapp template folder (requires Moodle 3.8)#702
Open
jrchamp wants to merge 2 commits intoncstate-delta:mainfrom
Open
ci: use recommended mobileapp template folder (requires Moodle 3.8)#702jrchamp wants to merge 2 commits intoncstate-delta:mainfrom
jrchamp wants to merge 2 commits intoncstate-delta:mainfrom
Conversation
jrchamp
added
bug
Contributor
|
I remember when we talked about these templates and why they were ignored. I'm so happy they will have a home now to be ignored without the special |
jrchamp
changed the title
Collaborator
Author
|
Note to self: It would be cleaner to fold #604 into this PR. They are both low-impact, backward-incompatible changes and modify some of the same lines, so let's not create merge conflicts for the maintainer. Even though the other change is older, this is the more-beneficial of the two and has the clearest requirements change. |
jrchamp
force-pushed
the
fix/move-mobile-templates
branch
from
c73970f to
4329c48
Compare
Contributor
|
This patch requires us to drop everything prior to 3.8. Moodle version 3.9 ended in December 2023 and I can see justifying dropping support for previous versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In moodle-plugin-ci 4.5.10, logic was added to treat the
templates/mobileappfolder as special. Initially, it means the templates are automatically skipped, but in the future there may be actually relevant checks performed on these mobile templates.Warning: Please note that Moodle added support for template folders in Moodle 3.8 (which we discovered previously in #398). Currently, this plugin only requires Moodle 3.7, so this would break compatibility and require an increase to the minimum supported version.